Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files

zipdiff/DifferenceCalculator.java

Error		Line
	Line does not match expected header line of ''.	1
	Using the '.*' form of import should be avoided - java.util.*.	3
	Using the '.*' form of import should be avoided - java.util.regex.*.	9
	Using the '.*' form of import should be avoided - java.io.*.	10
	Line has trailing spaces.	16
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Method 'debug' is not designed for extension - needs to be abstract, final or empty.	31
	Missing a Javadoc comment.	31
	Parameter msg should be final.	31
	Line is longer than 80 characters.	33
	Method 'setVerbose' is not designed for extension - needs to be abstract, final or empty.	41
	Parameter b should be final.	41
	Method 'isVerboseEnabled' is not designed for extension - needs to be abstract, final or empty.	45
	Missing a Javadoc comment.	45
	First sentence should end with a period.	49
	Line contains a tab character.	49
	Line contains a tab character.	50
	Line contains a tab character.	51
	Line contains a tab character.	52
	Line is longer than 80 characters.	53
	Parameter filename1 should be final.	53
	Expected @param tag for 'filename1'.	53
	Parameter filename2 should be final.	53
	Expected @param tag for 'filename2'.	53
	Expected @throws tag for 'java.io.IOException'.	53
	First sentence should end with a period.	57
	Line contains a tab character.	57
	Line contains a tab character.	58
	Line contains a tab character.	59
	Line contains a tab character.	60
	Parameter f1 should be final.	61
	Expected @param tag for 'f1'.	61
	Parameter f2 should be final.	61
	Expected @param tag for 'f2'.	61
	Expected @throws tag for 'java.io.IOException'.	61
	First sentence should end with a period.	65
	Line contains a tab character.	65
	Line contains a tab character.	66
	Line contains a tab character.	67
	Line contains a tab character.	68
	Parameter zf1 should be final.	68
	Expected @param tag for 'zf1'.	68
	Parameter zf2 should be final.	68
	Expected @param tag for 'zf2'.	68
	Line contains a tab character.	69
	Line contains a tab character.	70
	Line contains a tab character.	71
	Line has trailing spaces.	74
	Line is longer than 80 characters.	75
	Unused @param tag for 'Set'.	75
	Method 'setFilenameRegexToIgnore' is not designed for extension - needs to be abstract, final or empty.	79
	Parameter patterns should be final.	79
	Expected @param tag for 'patterns'.	79
	Line has trailing spaces.	102
	Line is longer than 80 characters.	103
	Unused @param tag for 'filename'.	103
	Method 'ignoreThisFile' is not designed for extension - needs to be abstract, final or empty.	106
	Parameter filepath should be final.	106
	Expected @param tag for 'filepath'.	106
	Parameter entryName should be final.	106
	Expected @param tag for 'entryName'.	106
	'}' should be on the same line.	109
	')' is preceded with whitespace.	110
	')' is preceded with whitespace.	110
	Line contains a tab character.	111
	Line is longer than 80 characters.	118
	Method 'isCVSFile' is not designed for extension - needs to be abstract, final or empty.	124
	Missing a Javadoc comment.	124
	Parameter filepath should be final.	124
	Parameter entryName should be final.	124
	'{' should be on the previous line.	125
	Line contains a tab character.	126
	Line contains a tab character.	127
	'{' should be on the previous line.	127
	Line contains a tab character.	128
	Line contains a tab character.	129
	'}' should be on the same line.	129
	Line is longer than 80 characters.	130
	Line contains a tab character.	130
	Conditional logic can be removed.	130
	'(' is followed by whitespace.	130
	Line contains a tab character.	131
	Line contains a tab character.	132
	Line contains a tab character.	133
	'}' should be on the same line.	133
	Line contains a tab character.	134
	Line contains a tab character.	135
	'{' should be on the previous line.	135
	Line contains a tab character.	136
	Line contains a tab character.	137
	Line contains a tab character.	139
	Line contains a tab character.	140
	Line contains a tab character.	141
	Line contains a tab character.	142
	Method 'setCompareCRCValues' is not designed for extension - needs to be abstract, final or empty.	143
	Parameter b should be final.	143
	Line contains a tab character.	147
	Line contains a tab character.	148
	Line contains a tab character.	149
	Method 'getCompareCRCValues' is not designed for extension - needs to be abstract, final or empty.	150
	Line is longer than 80 characters.	155
	Line is longer than 80 characters.	158
	Method 'buildZipEntryMap' is not designed for extension - needs to be abstract, final or empty.	161
	Parameter zf should be final.	161
	Expected @throws tag for 'java.io.IOException'.	161
	Line contains a tab character.	164
	Line contains a tab character.	165
	Line contains a tab character.	166
	Line contains a tab character.	167
	Line contains a tab character.	168
	Line contains a tab character.	169
	Line contains a tab character.	170
	Line contains a tab character.	171
	Line contains a tab character.	172
	Line contains a tab character.	173
	Line contains a tab character.	174
	Line contains a tab character.	175
	Line contains a tab character.	176
	Line is longer than 80 characters.	185
	Line is longer than 80 characters.	186
	Line has trailing spaces.	188
	Line is longer than 80 characters.	188
	Line is longer than 80 characters.	189
	Line is longer than 80 characters.	191
	Line is longer than 80 characters.	194
	Line is longer than 80 characters.	198
	Method 'processZipEntry' is not designed for extension - needs to be abstract, final or empty.	198
	Parameter prefix should be final.	198
	Parameter zipEntry should be final.	198
	Parameter is should be final.	198
	Parameter zipEntryMap should be final.	198
	Expected @throws tag for 'IOException'.	198
	Line is longer than 80 characters.	200
	Line contains a tab character.	200
	Line is longer than 80 characters.	209
	Line is longer than 80 characters.	217
	Method 'processEmbeddedZipFile' is not designed for extension - needs to be abstract, final or empty.	217
	Missing a Javadoc comment.	217
	Parameter prefix should be final.	217
	Parameter is should be final.	217
	Parameter m should be final.	217
	Parameter filename should be final.	236
	Line has trailing spaces.	263
	Line is longer than 80 characters.	270
	Method 'calculateDifferences' is not designed for extension - needs to be abstract, final or empty.	270
	Parameter zf1 should be final.	270
	Parameter zf2 should be final.	270
	Expected @throws tag for 'java.io.IOException'.	270
	Line has trailing spaces.	279
	Method 'calculateDifferences' is not designed for extension - needs to be abstract, final or empty.	282
	Parameter m1 should be final.	282
	Expected @param tag for 'm1'.	282
	Parameter m2 should be final.	282
	Expected @param tag for 'm2'.	282
	Must have at least one statement.	295
	Line contains a tab character.	296
	'}' should be on the same line.	297
	Line is longer than 80 characters.	317
	Method 'entriesMatch' is not designed for extension - needs to be abstract, final or empty.	323
	Parameter entry1 should be final.	323
	Parameter entry2 should be final.	323
	Method 'setIgnoreTimestamps' is not designed for extension - needs to be abstract, final or empty.	342
	Missing a Javadoc comment.	342
	Parameter b should be final.	342
	Method 'isIgnoringTimestamps' is not designed for extension - needs to be abstract, final or empty.	346
	Missing a Javadoc comment.	346
	Method 'ignoreCVSFiles' is not designed for extension - needs to be abstract, final or empty.	350
	Missing a Javadoc comment.	350
	'{' should be on the previous line.	351
	Line contains a tab character.	352
	Method 'setIgnoreCVSFiles' is not designed for extension - needs to be abstract, final or empty.	355
	Missing a Javadoc comment.	355
	Parameter b should be final.	355
	'{' should be on the previous line.	356
	Line contains a tab character.	357
	Line has trailing spaces.	359
	Line has trailing spaces.	361
	Method 'getDifferences' is not designed for extension - needs to be abstract, final or empty.	365
	Expected @throws tag for 'java.io.IOException'.	365

zipdiff/Differences.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	Using the '.*' form of import should be avoided - java.util.*.	7
	Line has trailing spaces.	12
	Missing a Javadoc comment.	16
	Missing a Javadoc comment.	17
	Missing a Javadoc comment.	18
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	23
	Line has trailing spaces.	24
	Method 'setFilename1' is not designed for extension - needs to be abstract, final or empty.	27
	Missing a Javadoc comment.	27
	Parameter filename should be final.	27
	Method 'setFilename2' is not designed for extension - needs to be abstract, final or empty.	31
	Missing a Javadoc comment.	31
	Parameter filename should be final.	31
	Method 'getFilename1' is not designed for extension - needs to be abstract, final or empty.	35
	Missing a Javadoc comment.	35
	Method 'getFilename2' is not designed for extension - needs to be abstract, final or empty.	39
	Missing a Javadoc comment.	39
	Method 'fileAdded' is not designed for extension - needs to be abstract, final or empty.	43
	Missing a Javadoc comment.	43
	Parameter fqn should be final.	43
	Parameter ze should be final.	43
	Method 'fileRemoved' is not designed for extension - needs to be abstract, final or empty.	47
	Missing a Javadoc comment.	47
	Parameter fqn should be final.	47
	Parameter ze should be final.	47
	Method 'fileIgnored' is not designed for extension - needs to be abstract, final or empty.	51
	Missing a Javadoc comment.	51
	Parameter fqn should be final.	51
	Parameter ze should be final.	51
	Method 'fileChanged' is not designed for extension - needs to be abstract, final or empty.	55
	Missing a Javadoc comment.	55
	Parameter fqn should be final.	55
	Parameter z1 should be final.	55
	Parameter z2 should be final.	55
	Method 'getAdded' is not designed for extension - needs to be abstract, final or empty.	62
	Missing a Javadoc comment.	62
	Method 'getRemoved' is not designed for extension - needs to be abstract, final or empty.	66
	Missing a Javadoc comment.	66
	Method 'getChanged' is not designed for extension - needs to be abstract, final or empty.	70
	Missing a Javadoc comment.	70
	Method 'getIgnored' is not designed for extension - needs to be abstract, final or empty.	74
	Missing a Javadoc comment.	74
	Method 'hasDifferences' is not designed for extension - needs to be abstract, final or empty.	78
	Missing a Javadoc comment.	78
	Line is longer than 80 characters.	79
	Method 'toString' is not designed for extension - needs to be abstract, final or empty.	82
	Missing a Javadoc comment.	82

zipdiff/Main.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	Using the '.*' form of import should be avoided - zipdiff.output.*.	11
	Using the '.*' form of import should be avoided - org.apache.commons.cli.*.	13
	First sentence should end with a period.	15
	Line has trailing spaces.	16
	Line has trailing spaces.	18
	Line has trailing spaces.	20
	Utility classes should not have a public or default constructor.	22
	Missing a Javadoc comment.	23
	Line contains a tab character.	24
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Line is longer than 80 characters.	32
	Missing a Javadoc comment.	32
	Line contains a tab character.	33
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Name 'options' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	34
	Line is longer than 80 characters.	41
	Line is longer than 80 characters.	45
	Line is longer than 80 characters.	48
	Line is longer than 80 characters.	51
	Line contains a tab character.	55
	Line contains a tab character.	56
	Line contains a tab character.	57
	Line contains a tab character.	58
	Line contains a tab character.	59
	Line has trailing spaces.	61
	Line is longer than 80 characters.	67
	Line contains a tab character.	71
	Line contains a tab character.	72
	Line contains a tab character.	73
	Line contains a tab character.	74
	Line contains a tab character.	75
	Line has trailing spaces.	77
	Line has trailing spaces.	78
	Line contains a tab character.	78
	Line contains a tab character.	79
	Line contains a tab character.	80
	Line contains a tab character.	81
	Line contains a tab character.	82
	Line is longer than 80 characters.	83
	Line contains a tab character.	83
	Line has trailing spaces.	84
	Line contains a tab character.	84
	Line has trailing spaces.	85
	Line contains a tab character.	85
	Line contains a tab character.	86
	Line contains a tab character.	87
	Line contains a tab character.	88
	Line contains a tab character.	89
	Line contains a tab character.	90
	Line has trailing spaces.	91
	Line contains a tab character.	91
	Missing a Javadoc comment.	103
	Parameter f should be final.	103
	Missing a Javadoc comment.	123
	Parameter filename should be final.	123
	Parameter d should be final.	123
	Line contains a tab character.	124
	'{' should be on the previous line.	125
	Line contains a tab character.	126
	Line contains a tab character.	127
	Line contains a tab character.	128
	'{' should be on the previous line.	128
	Line contains a tab character.	129
	Line contains a tab character.	130
	'}' should be on the same line.	130
	Line contains a tab character.	131
	Line contains a tab character.	132
	'{' should be on the previous line.	132
	Line contains a tab character.	133
	Line contains a tab character.	134
	'}' should be on the same line.	134
	Line has trailing spaces.	135
	Line contains a tab character.	135
	Line contains a tab character.	136
	'{' should be on the previous line.	136
	Line contains a tab character.	137
	Line contains a tab character.	138
	Line contains a tab character.	139
	Line has trailing spaces.	140
	Line contains a tab character.	140
	Line has trailing spaces.	142
	First sentence should end with a period.	143
	Line contains a tab character.	143
	Line has trailing spaces.	144
	Line contains a tab character.	144
	Line contains a tab character.	145
	Line has trailing spaces.	146
	Line contains a tab character.	146
	Line contains a tab character.	147
	Line has trailing spaces.	148
	Line contains a tab character.	148
	Line contains a tab character.	149
	Parameter args should be final.	150
	Line contains a tab character.	184
	Line contains a tab character.	186
	Line has trailing spaces.	188
	Line has trailing spaces.	202
	Line contains a tab character.	205
	Line has trailing spaces.	207
	Line has trailing spaces.	209
	'{' should be on the previous line.	211
	Line contains a tab character.	212
	Line contains a tab character.	213
	Line has trailing spaces.	215
	Line has trailing spaces.	216
	Line contains a tab character.	218
	Line contains a tab character.	219
	Line is longer than 80 characters.	220
	Line contains a tab character.	220
	Line contains a tab character.	221
	Line has trailing spaces.	223
	Line contains a tab character.	223

zipdiff/ant/ZipDiffTask.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	Using the '.*' form of import should be avoided - zipdiff.output.*.	10
	Line has trailing spaces.	15
	Line has trailing spaces.	16
	Line has trailing spaces.	19
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Method 'setFilename1' is not designed for extension - needs to be abstract, final or empty.	29
	Missing a Javadoc comment.	29
	Parameter name should be final.	29
	Method 'setFilename2' is not designed for extension - needs to be abstract, final or empty.	33
	Missing a Javadoc comment.	33
	Parameter name should be final.	33
	Method 'setIgnoreTimestamps' is not designed for extension - needs to be abstract, final or empty.	37
	Missing a Javadoc comment.	37
	Parameter b should be final.	37
	Method 'getIgnoreTimestamps' is not designed for extension - needs to be abstract, final or empty.	41
	Missing a Javadoc comment.	41
	Method 'setIgnoreCVSFiles' is not designed for extension - needs to be abstract, final or empty.	45
	Missing a Javadoc comment.	45
	Parameter b should be final.	45
	'{' should be on the previous line.	46
	Line contains a tab character.	47
	Line has trailing spaces.	49
	Method 'getIgnoreCVSFiles' is not designed for extension - needs to be abstract, final or empty.	50
	Missing a Javadoc comment.	50
	Line contains a tab character.	51
	Line has trailing spaces.	53
	Method 'setCompareCRCValues' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Parameter b should be final.	54
	Method 'getCompareCRCValues' is not designed for extension - needs to be abstract, final or empty.	58
	Missing a Javadoc comment.	58
	Method 'execute' is not designed for extension - needs to be abstract, final or empty.	62
	Missing a Javadoc comment.	62
	Redundant throws: 'BuildException' is unchecked exception.	62
	Method 'writeDestFile' is not designed for extension - needs to be abstract, final or empty.	79
	Missing a Javadoc comment.	79
	Parameter d should be final.	79
	Method 'getDestFile' is not designed for extension - needs to be abstract, final or empty.	95
	Missing a Javadoc comment.	95
	Method 'setDestFile' is not designed for extension - needs to be abstract, final or empty.	99
	Missing a Javadoc comment.	99
	Parameter name should be final.	99
	Method 'calculateDifferences' is not designed for extension - needs to be abstract, final or empty.	103
	Missing a Javadoc comment.	103
	Redundant throws: 'BuildException' is unchecked exception.	103
	Method 'validate' is not designed for extension - needs to be abstract, final or empty.	124
	Missing a Javadoc comment.	124
	Redundant throws: 'BuildException' is unchecked exception.	124

zipdiff/output/AbstractBuilder.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	Using the '.*' form of import should be avoided - java.io.*.	8
	Line has trailing spaces.	11
	Line has trailing spaces.	14
	Line has trailing spaces.	15
	Line contains a tab character.	18
	'{' should be on the previous line.	19
	Line contains a tab character.	20
	Method 'build' is not designed for extension - needs to be abstract, final or empty.	20
	Missing a Javadoc comment.	20
	Parameter filename should be final.	20
	Parameter d should be final.	20
	Line contains a tab character.	21
	'{' should be on the previous line.	21
	Line contains a tab character.	22
	Line has trailing spaces.	23
	Line contains a tab character.	23
	Line contains a tab character.	24
	Line contains a tab character.	25
	Line contains a tab character.	26
	Line contains a tab character.	27
	Line has trailing spaces.	28
	Line contains a tab character.	28
	Line contains a tab character.	29
	Missing a Javadoc comment.	29
	Parameter out should be final.	29
	Parameter d should be final.	29

zipdiff/output/Builder.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	First sentence should end with a period.	11
	Line has trailing spaces.	12
	Line is longer than 80 characters.	13
	Line has trailing spaces.	15
	Line contains a tab character.	20
	Missing a Javadoc comment.	20
	Redundant 'public' modifier.	20
	Line is longer than 80 characters.	21
	Line contains a tab character.	21
	Missing a Javadoc comment.	21
	Redundant 'public' modifier.	21

zipdiff/output/HtmlBuilder.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	First sentence should end with a period.	13
	Line has trailing spaces.	14
	Line has trailing spaces.	16
	Line has trailing spaces.	19
	Method 'build' is not designed for extension - needs to be abstract, final or empty.	23
	Missing a Javadoc comment.	23
	Parameter out should be final.	23
	Parameter d should be final.	23
	Line is longer than 80 characters.	32
	Line has trailing spaces.	33
	Method 'writeAdded' is not designed for extension - needs to be abstract, final or empty.	69
	Missing a Javadoc comment.	69
	Parameter pw should be final.	69
	Parameter added should be final.	69
	Line contains a tab character.	70
	Method 'writeRemoved' is not designed for extension - needs to be abstract, final or empty.	73
	Missing a Javadoc comment.	73
	Parameter pw should be final.	73
	Parameter removed should be final.	73
	Line contains a tab character.	74
	Method 'writeChanged' is not designed for extension - needs to be abstract, final or empty.	77
	Missing a Javadoc comment.	77
	Parameter pw should be final.	77
	Parameter changed should be final.	77
	Line contains a tab character.	78
	Method 'writeDiffSet' is not designed for extension - needs to be abstract, final or empty.	81
	Missing a Javadoc comment.	81
	Parameter pw should be final.	81
	Parameter name should be final.	81
	Parameter s should be final.	81
	Line is longer than 80 characters.	82
	Line contains a tab character.	82
	Line contains a tab character.	83
	Line is longer than 80 characters.	84
	Method 'getStyleTag' is not designed for extension - needs to be abstract, final or empty.	107
	Missing a Javadoc comment.	107
	'{' should be on the previous line.	108
	Line has trailing spaces.	110
	Line contains a tab character.	117
	Line has trailing spaces.	123
	Line contains a tab character.	123
	Line has trailing spaces.	128
	Line has trailing spaces.	130

zipdiff/output/TextBuilder.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	Line has trailing spaces.	13
	Line contains a tab character.	18
	Method 'build' is not designed for extension - needs to be abstract, final or empty.	18
	Missing a Javadoc comment.	18
	Parameter out should be final.	18
	Parameter d should be final.	18
	Line contains a tab character.	19
	Line contains a tab character.	20
	Line contains a tab character.	21
	Line contains a tab character.	22

zipdiff/output/XmlBuilder.java

Error		Line
	Line does not match expected header line of ''.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	3
	First sentence should end with a period.	13
	Line has trailing spaces.	14
	Line has trailing spaces.	16
	Line has trailing spaces.	18
	Method 'build' is not designed for extension - needs to be abstract, final or empty.	22
	Missing a Javadoc comment.	22
	Parameter out should be final.	22
	Parameter d should be final.	22
	Method 'writeAdded' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Parameter pw should be final.	54
	Parameter added should be final.	54
	Method 'writeRemoved' is not designed for extension - needs to be abstract, final or empty.	65
	Missing a Javadoc comment.	65
	Parameter pw should be final.	65
	Parameter removed should be final.	65
	Method 'writeChanged' is not designed for extension - needs to be abstract, final or empty.	75
	Missing a Javadoc comment.	75
	Parameter pw should be final.	75
	Parameter changed should be final.	75